Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update collator candidate self-bond in Moonbeam #2174

Merged
merged 8 commits into from
Apr 3, 2023

Conversation

Agusrodri
Copy link
Contributor

@Agusrodri Agusrodri commented Mar 20, 2023

What does it do?

According to this referenda https://moonbeam.polkassembly.io/referendum/88, the change proposed in this PR is the one that refers to update the bond to 2,000,000 GLMR in order the collator to be considered eligible and become a collator candidate. The current bond is 100,000 GLMR.

⚠️ Breaking Changes ⚠️

  • All changes are moonbeam only.
  • Changed both MinCandidateStk and MinCollatorStk constants to the value of 2,000,000 GLMR.

Notes

  • MinCandidateStk refers to the minimum stake required to be reserved to be a candidate. Located in the moonbeam runtime Config (lib file).
  • MinCollatorStk refers to the minimum stake required to become a collator. Located in the moonbeam runtime Config (lib file).

@Agusrodri Agusrodri added B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. D10-breaksdocs Changes to code that require changes in documentation breaking Needs to be mentioned in breaking changes labels Mar 20, 2023
@Agusrodri Agusrodri changed the title changed collator bond constants in Moonbeam Update collator candidate self-bond in Moonbeam Mar 20, 2023
@Agusrodri Agusrodri marked this pull request as draft March 20, 2023 23:56
@Agusrodri Agusrodri changed the title Update collator candidate self-bond in Moonbeam Moonbeam: update collator candidate self-bond Mar 21, 2023
@Agusrodri Agusrodri marked this pull request as ready for review March 21, 2023 16:18
runtime/moonbeam/src/lib.rs Outdated Show resolved Hide resolved
@Agusrodri Agusrodri requested a review from 4meta5 March 21, 2023 18:43
@Agusrodri Agusrodri merged commit bcc8988 into master Apr 3, 2023
@Agusrodri Agusrodri deleted the agustin-self-bond-moonbeam branch April 3, 2023 16:34
@crystalin crystalin changed the title Moonbeam: update collator candidate self-bond Update collator candidate self-bond in Moonbeam Apr 13, 2023
@notlesh notlesh added D1-audited👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited and removed D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Apr 26, 2023
imstar15 pushed a commit to AvaProtocol/moonbeam that referenced this pull request May 16, 2023
* changed collator bond constants in Moonbeam

* fix unit tests

* fix reward_block_authors unit test

* fix reward_bock_authors_with_bond test

* fix chain_spec

* updated chain_spec collator balances

* fixed initial balance in moonbeam chain_spec

* fix constants syntax
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes breaking Needs to be mentioned in breaking changes D1-audited👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited D10-breaksdocs Changes to code that require changes in documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants