Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow proxy precompile to perform subcalls and to be callable from batch on Moonriver/Moonbeam #2177

Merged
merged 2 commits into from
Mar 22, 2023

Conversation

librelois
Copy link
Collaborator

@librelois librelois commented Mar 21, 2023

What does it do?

A misconfiguration in the proxy precompile on Moonriver/Moonbeam block any attemp to perform a proxied call with revert error subcalls disabled for this precompile.

This PR adapt the proxy precompile cofniguration to allow evm subcalls, and also allow the batch precompile to call the proxy precompile to allow to batch several proxied calls in one transaction.

@librelois librelois added B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Mar 21, 2023
Copy link
Contributor

@nbaztec nbaztec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering in my PR why moonriver and moonbeam had different config to moonbase (I assumed we were testing on moonbase first) :P

@nbaztec nbaztec added the breaking Needs to be mentioned in breaking changes label Mar 21, 2023
@librelois librelois merged commit eb50d28 into master Mar 22, 2023
@librelois librelois deleted the elois-fix-proxy-proxy- branch March 22, 2023 14:53
@notlesh notlesh added D1-audited👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited and removed D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Apr 26, 2023
imstar15 pushed a commit to AvaProtocol/moonbeam that referenced this pull request May 16, 2023
…tch on Moonriver/Moonbeam (moonbeam-foundation#2177)

* allow proxy precompile to perform subcalls and to be callable from batch

* fix imports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes breaking Needs to be mentioned in breaking changes D1-audited👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants