Switch to stable rust and make rust debug build usable #2207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
librelois
added
B7-runtimenoteworthy
nbaztec
approved these changes
Apr 4, 2023
|
I believe cargo-expand requires nightly rust to work. I found this workaround, not sure if it is a good idea though: |
|
Thank you @tmpolaczyk for the suggestion but we can't inject an environment variable on cargo expand run, it will require a contribution to the |
imstar15
pushed a commit
to OAK-Foundation/moonbeam
that referenced
this pull request
May 16, 2023
…dation#2207) * make moonnbeam compiling with stable rust * make rust dev mode usable * toml-sort * macro tests: update compile error outputs * macro tests: update expanded outputs * rebuild cargo-expand with stable rust * cargo expand is not supported in stable rust
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
This pull request brings support for compiling moonbeam with stable Rust, this required to cherry-pick paritytech/substrate#13580 on our substrate branch
moonbeam-polkadot-v0.9.38.This PR also allows to use the moonbeam binary in debug build (much faster compilation), to achieve this we use the same trick as parity on these substrate and polkadot repos: force the optimized compilation only for the few low-level crates that need it.
What important points reviewers should know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?