Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve XCM v2 compatibility modifying proof size #2228

Merged
merged 4 commits into from
Apr 14, 2023

Conversation

girazoki
Copy link
Collaborator

What does it do?

Modifies proof sizes on moonriver and moonbeam runtimes to be compliant with V2->V3 BuyExecution transalations

What important points reviewers should know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?

What value does it bring to the blockchain users?

@girazoki girazoki changed the title Proof size of 0 for XCM MOdify proof size for XCM Apr 14, 2023
@girazoki girazoki added A0-pleasereview Pull request needs code review. breaking Needs to be mentioned in breaking changes D9-needsaudit👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes labels Apr 14, 2023
@girazoki girazoki merged commit 19da0a7 into master Apr 14, 2023
@girazoki girazoki deleted the girazoki-xcm-proof-size branch April 14, 2023 13:05
@crystalin crystalin changed the title MOdify proof size for XCM Improve XCM v2 compatibility modifying proof size Apr 14, 2023
imstar15 pushed a commit to AvaProtocol/moonbeam that referenced this pull request May 16, 2023
* Proof size of 0 for XCM

* Remove unused imports

* FMT

* added test

---------

Co-authored-by: timbrinded <79199034+timbrinded@users.noreply.github.com>
@notlesh notlesh added D1-audited👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited and removed D9-needsaudit👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited labels May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A0-pleasereview Pull request needs code review. B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes breaking Needs to be mentioned in breaking changes D1-audited👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants