Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update some dependencies #2263

Merged
merged 2 commits into from May 26, 2023
Merged

Update some dependencies #2263

merged 2 commits into from May 26, 2023

Conversation

tmpolaczyk
Copy link
Contributor

What does it do?

Updates some dependencies to fix warnings about remove_dir_all and enumflags2. chrono and time are also updated, but that doesn't fix anything.

Is there something left for follow-up PRs?

Getting rid of the chrono dependency would be nice as that issues some false positives regarding to the time crate.

@tmpolaczyk tmpolaczyk added B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit not-breaking Does not need to be mentioned in breaking changes labels Apr 25, 2023
@librelois
Copy link
Collaborator

Your changes duplicate the syn dependency, can you fix that?

@tmpolaczyk
Copy link
Contributor Author

@librelois yeah, that's unfortunate, but the only version of enumflags2 that has not been yanked is using syn 2: https://crates.io/crates/enumflags2/versions

This is the advisory that explains why it has been yanked, it probably doesn't affect us so I could remove that upgrade from this PR:

GHSA-qvc4-78gw-pv8p

But I believe that it is impossible to get all of the dependencies to upgrade from syn 1 to syn 2 simultaneously, so we will encounter this problem again in the future.

@crystalin
Copy link
Collaborator

@tmpolaczyk can you cleanup this PR or close if not needed anymore please ?

@github-actions
Copy link
Contributor

Coverage generated "Fri May 26 07:12:47 UTC 2023":
https://s3.amazonaws.com/moonbeam-coverage/pulls/2263/html/index.html

Master coverage: 70.88%
Pull coverage: 70.88%

@tmpolaczyk
Copy link
Contributor Author

Updated with master. The syn dependency is already duplicated in master so that's no longer a problem for this PR.

@crystalin crystalin merged commit e6a8cf2 into master May 26, 2023
26 checks passed
@crystalin crystalin deleted the tomasz-update-deps-2 branch May 26, 2023 12:24
@crystalin
Copy link
Collaborator

Thank you @tmpolaczyk

timbrinded pushed a commit that referenced this pull request Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit not-breaking Does not need to be mentioned in breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants