Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Unlimited weight to Xtokens precompile #2307

Merged
merged 1 commit into from May 19, 2023

Conversation

Agusrodri
Copy link
Contributor

@Agusrodri Agusrodri commented May 17, 2023

What does it do?

Xtokens pallet allows users to use the Unlimited weight variant. On the other hand, current Xtokens precompile doesn't allow this functionality. This PR enables it.

If users want to use the Unlimited variant in any of the functions present in Xtokens precompile, they must pass a uint64::MAX through the weight parameter.

Changes

  • The code for Xtokens precompile functions was modified to detect the case of uint64::MAX in weight field. If that's the case, the Unlimited weight variant will be applied.

@Agusrodri Agusrodri added B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit not-breaking Does not need to be mentioned in breaking changes labels May 17, 2023
@Agusrodri Agusrodri requested a review from librelois May 17, 2023 16:00
@github-actions
Copy link
Contributor

Coverage generated "Wed May 17 16:48:14 UTC 2023":
https://s3.amazonaws.com/moonbeam-coverage/pulls/2307/html/index.html

Master coverage: 72.40%
Pull coverage: 72.41%

@Agusrodri Agusrodri merged commit fc1fd7b into master May 19, 2023
32 checks passed
@Agusrodri Agusrodri deleted the agustin-unlimited-xtokens branch May 19, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit not-breaking Does not need to be mentioned in breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants