New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix eth call gas estimation discrepancy #2440

Merged

librelois merged 6 commits into master from elois-fix-eth-call-diff

Aug 24, 2023

Collaborator

librelois commented Aug 16, 2023 •

edited

What does it do?

Fix a discrepancy bug between eth_call and on-chain tx execution.
The bug is caused by the fact that the PoV consumed by the ethereum transaction is counted differently in the estimation context than in the on-chain context.
The discrepancy is due to the fact that estimation queries generally not provide values for fields max_fee_per_gas and max_priority_fee_per_gas whereas the on-chain transaction provides values for these fields.

The solution is to consider that these fields are always supplied to estimate the size of the on-chain transaction, this implies over-estimation of 45 gas (negligible for fees) only for legacy transactions and only if the "pov gas" is greater than the used gas.

What important points reviewers should know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?

What value does it bring to the blockchain users?

librelois and others added 2 commits

August 15, 2023 20:28


          fix tx encoded size estimation

061c3e0


          Working test

66efcee

librelois added B7-runtimenoteworthy D5-nicetohaveaudit⚠️ not-breaking labels

librelois marked this pull request as ready for review

August 16, 2023 12:24

Contributor

github-actions bot commented Aug 16, 2023 •

edited

Coverage generated "Thu Aug 24 18:06:40 UTC 2023":
https://d3ifz9vhxc2wtb.cloudfront.net/pulls/2440/html/index.html

Master coverage: 87.39%
Pull coverage:

librelois requested review from crystalin, notlesh and Agusrodri

August 17, 2023 18:31

Agusrodri approved these changes

View reviewed changes

Contributor

Agusrodri left a comment

Some small comments regarding code cleanup mostly. LGTM.

tests/tests/test-gas/test-gas-foreign-asset.ts Outdated

Comment on lines 60 to 70

+                  // const { result } = await context.createBlock(
+                  //   await createTransaction(context, {
+                  //     ...CHARLETH_TRANSACTION_TEMPLATE,
+                  //     to: ADDRESS_ERC20,
+                  //     data: ERC20_INTERFACE.encodeFunctionData("approve", [alith.address, 100000000]),
+                  //   })
+                  // );
+                  // const receipt = await context.web3.eth.getTransactionReceipt(result.hash);
+                  // console.log("Zero approve gas used", receipt.gasUsed);
+                  // expect(receipt.status).to.equal(true);

Contributor

Agusrodri Aug 17, 2023

Suggested change

      
                // const { result } = await context.createBlock(
          
                //   await createTransaction(context, {
          
                //     ...CHARLETH_TRANSACTION_TEMPLATE,
          
                //     to: ADDRESS_ERC20,
          
                //     data: ERC20_INTERFACE.encodeFunctionData("approve", [alith.address, 100000000]),
          
                //   })
          
                // );
          
                // const receipt = await context.web3.eth.getTransactionReceipt(result.hash);
          
                // console.log("Zero approve gas used", receipt.gasUsed);
          
                // expect(receipt.status).to.equal(true);

tests/tests/test-gas/test-gas-foreign-asset.ts Outdated

+                  let gasEst = await context.web3.eth.estimateGas({
+                    from: alith.address,
+                    data: ERC20_INTERFACE.encodeFunctionData("approve", [baltathar.address, 0]),
+                    // gasPrice: "0x0",

Contributor

Agusrodri Aug 17, 2023

Suggested change

// gasPrice: "0x0",

tests/tests/test-gas/test-gas-foreign-asset.ts Outdated

Comment on lines 3 to 4

		import { KeyringPair } from "@polkadot/keyring/types";
		import { ParaId } from "@polkadot/types/interfaces";

Contributor

Agusrodri Aug 17, 2023

Seems that these imports are not used

Suggested change

      
            import { KeyringPair } from "@polkadot/keyring/types";
          
            import { ParaId } from "@polkadot/types/interfaces";

tests/tests/test-gas/test-gas-foreign-asset.ts Outdated

+              import { KeyringPair } from "@polkadot/keyring/types";
+              import { ParaId } from "@polkadot/types/interfaces";
+              import { BN, hexToU8a, numberToHex, stringToHex, u8aToHex } from "@polkadot/util";

Contributor

Agusrodri Aug 17, 2023

Suggested change

      
            import { BN, hexToU8a, numberToHex, stringToHex, u8aToHex } from "@polkadot/util";
          
            import { BN, hexToU8a, u8aToHex } from "@polkadot/util";

tests/tests/test-gas/test-gas-foreign-asset.ts Outdated

+              import { blake2AsU8a, xxhashAsU8a } from "@polkadot/util-crypto";
+              import { expect } from "chai";
+              import { ALITH_ADDRESS, alith, baltathar, generateKeyringPair } from "../../util/accounts";

Contributor

Agusrodri Aug 17, 2023

Suggested change

      
            import { ALITH_ADDRESS, alith, baltathar, generateKeyringPair } from "../../util/accounts";
          
            import { ALITH_ADDRESS, alith, baltathar } from "../../util/accounts";

tests/tests/test-gas/test-gas-foreign-asset.ts Outdated

+              import { expect } from "chai";
+              import { ALITH_ADDRESS, alith, baltathar, generateKeyringPair } from "../../util/accounts";
+              import { PARA_2000_SOURCE_LOCATION, RELAY_SOURCE_LOCATION } from "../../util/assets";

Contributor

Agusrodri Aug 17, 2023

Suggested change

      
            import { PARA_2000_SOURCE_LOCATION, RELAY_SOURCE_LOCATION } from "../../util/assets";
          
            import { RELAY_SOURCE_LOCATION } from "../../util/assets";

tests/tests/test-gas/test-gas-foreign-asset.ts Outdated

Comment on lines 11 to 17

+              import {
+                registerForeignAsset,
+                injectHrmpMessageAndSeal,
+                RawXcmMessage,
+                XcmFragment,
+                weightMessage,
+              } from "../../util/xcm";

Contributor

Agusrodri Aug 17, 2023

Suggested change

      
            import {
          
              registerForeignAsset,
          
              injectHrmpMessageAndSeal,
          
              RawXcmMessage,
          
              XcmFragment,
          
              weightMessage,
          
            } from "../../util/xcm";
          
            import { registerForeignAsset } from "../../util/xcm";

tests/tests/test-gas/test-gas-foreign-asset.ts Outdated

+                XcmFragment,
+                weightMessage,
+              } from "../../util/xcm";
+              import { customWeb3Request, web3EthCall } from "../../util/providers";

Contributor

Agusrodri Aug 17, 2023

Suggested change

import { customWeb3Request, web3EthCall } from "../../util/providers";

tests/tests/test-gas/test-gas-foreign-asset.ts Outdated


		import { describeDevMoonbeam } from "../../util/setup-dev-tests";

		import { expectOk } from "../../util/expect";

Contributor

Agusrodri Aug 17, 2023

Suggested change

import { expectOk } from "../../util/expect";

Agusrodri reviewed

View reviewed changes

tests/tests/test-gas/test-gas-foreign-asset.ts Outdated

+                  );
+                  const receipt = await context.web3.eth.getTransactionReceipt(result.hash);
+                  console.log("First approve gas used", receipt.gasUsed);

Contributor

Agusrodri Aug 17, 2023 •

edited

Shouldn't we avoid console.logging inside TS tests? I think we had console.log() related issues in our CI in the past (correct me if I'm wrong).

Suggested change

console.log("First approve gas used", receipt.gasUsed);

Agusrodri reviewed

View reviewed changes

tests/tests/test-gas/test-gas-foreign-asset.ts Outdated

+                    to: ADDRESS_ERC20,
+                  });
+                  console.log("Revoke gas estimate", gasEst);

Contributor

Agusrodri Aug 17, 2023

Same case here

Suggested change

console.log("Revoke gas estimate", gasEst);

Agusrodri reviewed

View reviewed changes

tests/tests/test-gas/test-gas-foreign-asset.ts Outdated

+                  );
+                  const receipt2 = await context.web3.eth.getTransactionReceipt(result2.hash);
+                  console.log("Revoke gas used", receipt2.gasUsed);

Contributor

Agusrodri Aug 17, 2023

Suggested change

console.log("Revoke gas used", receipt2.gasUsed);

librelois added 2 commits

August 17, 2023 21:52


          test cleanup


          test cleanup 2

ab8234e

notlesh reviewed

View reviewed changes

runtime/common/src/apis.rs Outdated

               						// 65 bytes signature
-;
+;

Contributor

notlesh Aug 17, 2023

How did we get 210 -> 255? If it's 2 * 32 from max_fee_per_gas and max_prority_fee_per_gas, shouldn't it be 274?

The numbers from the comments do add up correctly to 255 at least...

Contributor

notlesh Aug 17, 2023

Also, it seems like we lost from. Is this because there is no such thing in an actual transaction (it's recovered from its signature)...?

Contributor

notlesh Aug 17, 2023 •

edited

from is 20, so 210 + 64 - 20 => 254, still off by one 😆

Collaborator Author

librelois Aug 18, 2023 •

edited

it seems like we lost from. Is this because there is no such thing in an actual transaction

Yes exactly

still off by one

The one come from access_list, even if the access list is empty, the scale encoded format take 1 byte for the empty Vec.

notlesh approved these changes

View reviewed changes

librelois added 2 commits

August 24, 2023 17:15


          accont for pallet index + call index+ transaction type enum variant

884143c


          pretiier

626cc33

librelois merged commit 85031d9 into master

26 checks passed

librelois deleted the elois-fix-eth-call-diff branch

August 24, 2023 23:07

grw-ms pushed a commit that referenced this pull request


          Fix eth call diff (#2440)

282ee7f

* fix tx encoded size estimation

* Working test

* test cleanup

* test cleanup 2

* accont for pallet index + call index+ transaction type enum variant

* pretiier

---------

Co-authored-by: Francisco Gamundi <francisco@moonsonglabs.com>

noandrea changed the title ~~Fix eth call diff~~ Fix eth call gas estimation discrepancy

notlesh added D1-audited👍 and removed D5-nicetohaveaudit⚠️ labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment