Update weights from new benchmarks #2547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noandrea
added
B7-runtimenoteworthy
crystalin
reviewed
Oct 31, 2023
| //! WORST CASE MAP SIZE: `1000000` | ||
| //! HOSTNAME: `ip-10-0-0-176`, CPU: `Intel(R) Xeon(R) Platinum 8375C CPU @ 2.90GHz` | ||
| //! EXECUTION: None, WASM-EXECUTION: Compiled, CHAIN: Some("moonbase-dev"), DB CACHE: 1024 | ||
| //! WASM-EXECUTION: `Compiled`, CHAIN: `Some("moonbase-dev")`, DB CACHE: 1024 |
There was a problem hiding this comment.
I see it was using EXECUTION: None before, I suspect it was wasm and not native @notlesh right ?
There was a problem hiding this comment.
Interesting, I think this is because the CLI options are ignored for wasm-execution now. But it hasn't made a difference in my testing...
the traits were removed by the automatic benchmarking
librelois
approved these changes
Nov 2, 2023
the change in weight is negligible but it has collateral effects for test execution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Generates weights for the runtime. Uses the ./scripts/run-benches-for-runtime.sh adapted from polkadot's. Each pallet has its own weight file that contains a generated trait WeightInfo as per the included template. Upon running the run-benches-for-runtime.sh the default template is used which merely implements the WeightInfo from the respective pallet's own weights.rs module, with the values for the current runtime.
The current PR uses weights generated by the benchmarking server, so is production-ready.
What important points reviewers should know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?