Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make min bound orbiter migration infaillible #2560

Merged
merged 2 commits into from
Nov 13, 2023
Merged

Conversation

librelois
Copy link
Collaborator

What does it do?

What important points reviewers should know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?

What value does it bring to the blockchain users?

@librelois librelois added B0-silent Changes should not be mentioned in any release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit labels Nov 13, 2023
Copy link
Collaborator

@noandrea noandrea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@librelois
Copy link
Collaborator Author

I tested the migration against the moonsama state with try-runtime and it work:

try-runtime --runtime target/release/wbuild/moonriver-runtime/moonriver_runtime.compact.compressed.wasm  on-runtime-upgrade --checks none live --uri wss://frag-moonsama-rpc-ws.g.moondev.network:443 -p MoonbeamOrbiters -p ParachainStaking

Copy link
Contributor

@rimbi rimbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@librelois librelois merged commit 365c60c into master Nov 13, 2023
27 of 28 checks passed
@librelois librelois deleted the elois-fix-migration branch November 13, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B0-silent Changes should not be mentioned in any release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants