Migrate Fee payment to use Fungible Adapter #2624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmadkaouk
added
B7-runtimenoteworthy
ahmadkaouk
changed the title
Coverage Report@@ Coverage Diff @@
## master ahmad-transferable-balance-fix +/- ##
==================================================================
+ Coverage 80.90% 80.95% +0.05%
Files 287 287
- Lines 94465 94367 -98
==================================================================
- Hits 76423 76392 -31
- Misses 18042 17975 -67
|
elfedy
approved these changes
Jan 29, 2024
| let total_supply_after = Balances::total_issuance(); | ||
| assert_eq!(total_supply_before - total_supply_after, 880); | ||
| }); | ||
| ExtBuilder::default().build().execute_with(|| { |
There was a problem hiding this comment.
Looking at this I do wonder if there's an alternative for duplicating tests like these
| @@ -271,33 +271,6 @@ export const verifyBlockFees = async ( | |||
| } | |||
| } | |||
| } | |||
| // Then search for Deposit event from treasury | |||
There was a problem hiding this comment.
should we be checking these from other event instead? say balances.Deposit on the treasury address or something?
Agusrodri
approved these changes
Jan 30, 2024
librelois
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
This PR fixes the transferable balance issue by migrating fee payment from Currency to fungible:
FungibleAdapterfor fee payment inpallet_transaction_paymentinstead ofCurrencyAdapterEVMFungibleAdapterfor fee payment inpallet_evminstead ofEVMCurrencyAdapterDealWithFeesimplementation to usefungibletraitsWhat important points reviewers should know?
The majority of the failed tests can be attributed to the fact that the new implementation no longer triggers the Treasury deposit event for fees.
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?