Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add benchmarks for runtime 2800 #2669

Merged
merged 6 commits into from Feb 22, 2024
Merged

Add benchmarks for runtime 2800 #2669

merged 6 commits into from Feb 22, 2024

Conversation

noandrea
Copy link
Collaborator

@noandrea noandrea commented Feb 22, 2024

What does it do?

Updates weights after running the benchmarks on the reference machine

What important points reviewers should know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?

What value does it bring to the blockchain users?

@noandrea noandrea added B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit breaking Needs to be mentioned in breaking changes labels Feb 22, 2024
Copy link
Collaborator

@librelois librelois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many weights are increasing a little, but that's good, because during peaks in activity some collators manage to produce blocks that are too big for the validators to check in time, which means that our weights are too optimistic.

Copy link
Contributor

github-actions bot commented Feb 22, 2024

Coverage Report

@@                     Coverage Diff                     @@
##           master   noandrea-benchmarks-2800     +/-   ##
===========================================================
  Coverage   73.68%                     73.68%   0.00%     
  Files         232                        232             
+ Lines       72749                      72750      +1     
===========================================================
- Hits        53604                      53603      -1     
+ Misses      19145                      19147      +2     
Files Changed Coverage

Coverage generated Thu Feb 22 19:29:54 UTC 2024

@noandrea noandrea merged commit e2fae82 into master Feb 22, 2024
29 checks passed
@noandrea noandrea deleted the noandrea-benchmarks-2800 branch February 22, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes breaking Needs to be mentioned in breaking changes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants