Increase block gas limit #2735
Merged
Increase block gas limit #2735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmadkaouk
added
B7-runtimenoteworthy
Coverage Report@@ Coverage Diff @@
## master ahmad-modify-parameters +/- ##
==========================================================
Coverage 72.46% 72.46% 0.00%
Files 229 229
Lines 70512 70512
==========================================================
Hits 51094 51094
Misses 19418 19418
|
RomarQ
reviewed
Apr 9, 2024
RomarQ
requested review from
noandrea,
elfedy,
librelois,
Agusrodri and
timbrinded
RomarQ
approved these changes
Apr 10, 2024
Agusrodri
reviewed
Apr 10, 2024
| // TARGET_FILL_AMOUNT that will result in a static fee multiplier | ||
| // console.log(`pre ${initialValue.toHuman()}`); | ||
| // console.log(`post ${postValue.toHuman()}`); | ||
| // console.log(`diff ${initialValue.sub(postValue)}`); |
There was a problem hiding this comment.
Is it planned to keep this comment?
Agusrodri
approved these changes
Apr 10, 2024
elfedy
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
15,000,000to60,000,000GasLimitPovSizeRatiofrom 4 to 16.BLOCK_STORAGE_LIMITfrom 40 Kb to 160 Kb.What important points reviewers should know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?