enable async backing client side for all runtimes #2778
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Enable async backing on the client side for moonriver and moonbeam.
Since Kusama enabled async backing on the relay config, parachain runtime require the inclusion of the parent parachain block head though the parachain system inherent, but moonkit include the parent head if and only if async backing is explicitly enabled client side, as a result collators with v0.37 can't produce blocks on moonriver as it panic at this line: https://github.com/moonbeam-foundation/polkadot-sdk/blob/moonbeam-polkadot-v1.3.0/cumulus/pallets/parachain-system/src/lib.rs#L1304
The only way to fix it is to enable async backing on the client side, it's fine to do that because moonkit with async backing enable still support old runtimes.
What important points reviewers should know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?