Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable async backing client side for all runtimes #2778

Merged
merged 1 commit into from Apr 22, 2024

Conversation

librelois
Copy link
Collaborator

What does it do?

Enable async backing on the client side for moonriver and moonbeam.

Since Kusama enabled async backing on the relay config, parachain runtime require the inclusion of the parent parachain block head though the parachain system inherent, but moonkit include the parent head if and only if async backing is explicitly enabled client side, as a result collators with v0.37 can't produce blocks on moonriver as it panic at this line: https://github.com/moonbeam-foundation/polkadot-sdk/blob/moonbeam-polkadot-v1.3.0/cumulus/pallets/parachain-system/src/lib.rs#L1304

The only way to fix it is to enable async backing on the client side, it's fine to do that because moonkit with async backing enable still support old runtimes.

What important points reviewers should know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?

What value does it bring to the blockchain users?

@librelois librelois added B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes not-breaking Does not need to be mentioned in breaking changes labels Apr 22, 2024
@librelois librelois merged commit 29db25c into perm-client-v0.37.1 Apr 22, 2024
19 of 22 checks passed
@librelois librelois deleted the enable-async-backing-client branch April 22, 2024 14:29
Copy link
Contributor

Coverage Report

@@                             Coverage Diff                             @@
##           perm-client-v0.37.1   enable-async-backing-client     +/-   ##
===========================================================================
  Coverage                73.06%                        73.06%   0.00%     
  Files                      228                           228             
  Lines                    69944                         69944             
===========================================================================
  Hits                     51103                         51103             
  Misses                   18841                         18841             
Files Changed Coverage

Coverage generated Mon Apr 22 15:00:43 UTC 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes not-breaking Does not need to be mentioned in breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants