Add balanced binary tree based immutable_set implementation #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this implementation is a bit confusing and may need to be more concise, I'm trying to refactor it... |
|
Now that the tests have passed, we can start to add documentation and tests based on add more functions ! |
|
I have added the functions required to satisfy the set definition (union, disjoint, subset, diff, inter), we also need general functions such as fold, map, filter etc. |
|
Is this PR ready now? |
Yes, I've done everything I planned and the local tests are passing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a set data structure without side effects based on a balanced binary tree, this means the add and find value take time logarithmic in the size of the set.