Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added OSC Layout and Visibility Configurability, #495, #450, #392, and #389 #546, #559 #565

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

King0fSpace
Copy link

Sorry about the delay.

Here is the rebased pull request that includes just the changes to allow for custom on screen control layouts.

Happy to make any changes requested.

This commit implements a feature discussed in #495 , #450 , #392 , and #389 .

It allows users to hide and move any of the on screen controller buttons anywhere they’d like on screen. The user can save their custom layouts under user-defined names. Multiple controller ‘profiles’ can be saved. Profiles can be loaded from a menu that lists all of the user’s saved profiles. The user can swipe-to-delete any user-saved profiles they'd like from this screen as well.

This feature has been made accessible in an unobtrusive way; by tapping the ‘Custom’ button added to the end of the existing ‘On-Screen Controls’ buttons bar, located within the existing ‘Settings’ slide out menu.

IMG_4526
IMG_4465
IMG_4466
7c93.jpeg)
IMG_4464
IMG_4463
IMG_4490
IMG_4470
IMG_4472

iPad
IMG_0047

@King0fSpace King0fSpace changed the title includes ability to customize on screen controls Added OSC Layout and Visibility Configurability, #495, #450, #392, and #389 #546 Jun 27, 2023
@King0fSpace King0fSpace changed the title Added OSC Layout and Visibility Configurability, #495, #450, #392, and #389 #546 Added OSC Layout and Visibility Configurability, #495, #450, #392, and #389 #546, #559 Jun 28, 2023
@xXJSONDeruloXx
Copy link

This looks great and is exactly want I've wanted for the iOS client. Can you look at addressing the merge conflicts? Or at least provide a TestFlight build I can join?

@xyaoo
Copy link

xyaoo commented Mar 19, 2024

When will this feature merge, which is very important to me and I've been waiting for it

@itzTheMeow
Copy link

I also think this should be merged.

@TrueZhuangJia
Copy link

TrueZhuangJia commented Jun 26, 2024

Anybody who's interested in this function please GO STAR IT!
https://github.com/King0fSpace/moonlight-ios-CustomOSC
image
only 3 stars for such a great feature, it's unfair..

Besides I made a better integration of this PR into moonlight-iOS 9.0.2, able to open the onscreen controller layout directly IN THE STREAM VIEW, with realtime game view, by simply tapping 4 fingers.
And seamless DUPLICATE, DELETE, Quick Load & modify Custom OSC layouts seamlessly directly IN THE STREAM VIEW.

Go to my relase page for the ipa file:
https://github.com/TrueZhuangJia/moonlight-ios-NativeMultiTouchPassthrough/releases/tag/betterGestureRecognizer

@xXJSONDeruloXx
Copy link

Anybody who's interested in this function please GO STAR IT!

https://github.com/King0fSpace/moonlight-ios-CustomOSC

image

only 3 stars for such a great feature, it's unfair..

Besides I made a better integration of this PR into moonlight-iOS 9.0.2, able to open the onscreen controller layout directly IN THE STREAM VIEW, with realtime game view, by simply tapping 4 fingers.

And seamless DUPLICATE, DELETE, Quick Load & modify Custom OSC layouts seamlessly directly IN THE STREAM VIEW.

Go to my relase page for the ipa file:

https://github.com/TrueZhuangJia/moonlight-ios-NativeMultiTouchPassthrough/releases/tag/betterGestureRecognizer

This is great work, would you consider submitting upstream?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants