Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wavy underlines do not scroll horizontally #39

Closed
doug777 opened this issue Oct 11, 2017 · 8 comments
Closed

Wavy underlines do not scroll horizontally #39

doug777 opened this issue Oct 11, 2017 · 8 comments
Assignees
Labels
Milestone

Comments

@doug777
Copy link

doug777 commented Oct 11, 2017

When moving pages from a Spark project into a FlexJS project, many tags and attributes are wavy underlined as expected. If you then horizontally scroll the page, the wavy underlines do not scroll with the rest of the page. Example image attached.

Doug
moonshine horiz scroll problem

@piotrzarzycki21
Copy link
Collaborator

Hi @doug777 ,

Could you tell in which version of Moonshine you experienced that issue ?

Thanks,
Piotr

@doug777
Copy link
Author

doug777 commented Oct 11, 2017

I'm using 1.5.1 in Win 10 Pro 64-bit and the project is using FlexJS 0.8.0 FP23.0 AIR23.0 en_US.

I have replied to emails from other issues I started, but looks like you have to sign in here and comment. Is that right?

Doug

@piotrzarzycki21
Copy link
Collaborator

@doug777 ,

Could you check whether you experienced that issue with our fresh released 1.6.0 version.

I'm not sure what do you mean by "sign in here and comment".

@doug777
Copy link
Author

doug777 commented Oct 11, 2017

Yes it's exactly the same in 1.6.0.

Doug

@piotrzarzycki21 piotrzarzycki21 added this to the v1.6.0 milestone Oct 12, 2017
joshtynjala added a commit that referenced this issue Oct 12, 2017
… on top of line numbers instead of below (references #39)
@JoelProminic
Copy link
Contributor

I was able to reproduce the horizontal scroll issue like this:

  1. Create a new FlexJS Project
  2. Make sure that the project is using a FlexJS SDK
  3. Add a long line of code with an error. The line needs to be long enough that it will require a horizontal scroll. I added an example below that will trigger both an error and a warning
  4. Slide the horizontal scroll bar. You should see that the wavy lines do not move
	<fx:Script>
		<![CDATA[
		private var  foo:String = doesNotExist + "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua." + doesNotExist2 + " Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat.";
		private var bar = "";
		]]>
	</fx:Script>

Unfortunately, I also noticed that the code overlaps with the sidebar.
2017_10_12__sidebaroverlap

Here is my test project, if you need it. I tested with Moonshine 1.6.0 on Mac OS 10.10.5:
2017_10_12__TestHorizontalScroll.zip

@JoelProminic
Copy link
Contributor

I noticed the update from @joshtynjala after I had written up my findings.

Testing with his updates, I found that the wavy underlines scrolled properly. However, I still see the new overlap issue I reported.

If this is an independent problem, then we should move it to a separate issue.

@JoelProminic JoelProminic reopened this Oct 12, 2017
@rat-moonshine
Copy link
Collaborator

I think the masking issue then a separate problem since @joshtynjala fix now moves wavy underlines properly. We should take the masking problem to a separate issue.

@rat-moonshine
Copy link
Collaborator

I've created a new issue on horizontal scroll masking here - #42 .

@piotrzarzycki21 piotrzarzycki21 moved this from In Progress to Done #1.6.0 in Moonshine-IDE - Bug Fixing Nov 10, 2017
rat-moonshine added a commit that referenced this issue Nov 10, 2021
- In-progress application add/edit window
- Data structure changes
(#39)
rat-moonshine added a commit that referenced this issue Nov 10, 2021
- Making data available to the new window and listens to its different handling
- Fixed data-inject in rootNavigatorController process
(#39)
rat-moonshine added a commit that referenced this issue Nov 10, 2021
- Opening Application download page
(#39)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

No branches or pull requests

5 participants