Fix for #2325 and #2364 (should also fix -more #1125)

[gonchuki]

remove Browser.ie check as Opera also returns non-numeric value when border.*Width is queried and that property is unset.

The fact that Opera returns "medium" when the border is unset must not be interpreted as 3px as suggested in #2364 since that string is actually a quirk from the browser (the border is actually 0px, Dragonfly properly shows this property as being unset in the layout pane).

[ibolmo]

Was there a failing spec? If not, we should have one that failed prior to the fix.

[gonchuki]

No failing spec but I can make one. Just not sure if this should go in 1.4client folder or create a 1.5 one.

[arian]

1.4client would be fine. Now we have this fix, we can pull it in 1.4.6. (both #2325 and #2364 have the 1.4.6 milestone.. :))

[arian]

Basically copy those two jsfiddles in the specs.. update it a bit.. check if it fails without the fix.. and verify it passes with the fix.

[ibolmo]

Right, and just try to run the specs against most browsers. I'm sure the rest of the team can cover any missing browsers before release.

Thanks @gonchuki .

[gonchuki]

I ended up creating my own specs as I wanted to test for all three failing properties (border.*Width was the culprit but it bubbled up to width/height to produce the NaNpx error)

for reference, this is the result of the failing specs:

should inherit the height from the child
Expected 'NaNpx' to equal '100px'.

should get a pixel based width
Expected 'NaNpx' to match /\d+px/.

should have a 0px border left
Expected 'medium' to equal '0px'.

my IE is not working right with the test suite so I couldn't run it, but unless these specs uncover new bugs the changed code was already IE-only so there's nothing new there.

[arian]

Looks awesome

merging...

[gonchuki]

If you don't mind to merge again/cherry-pick (or manually edit), I acidentally left a trailing comma on the spec
gonchuki@7f59171

[arian]

pulled

On Fri, Aug 10, 2012 at 4:43 PM, gonchuki notifications@github.com wrote:

If you don't mind to merge again/cherry-pick (or manually edit), I
acidentally left a trailing comma on the spec

gonchuki@7f59171

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/2401#issuecomment-7646494.