fix IE version detection in old IE #2653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergioCrisostomo
force-pushed
the
ie-version-fix
branch
2 times, most recently
from
a9b2fd6
to
6824ee0
Compare
| @@ -46,7 +46,7 @@ var parse = function(ua, platform){ | |||
| var Browser = this.Browser = parse(navigator.userAgent, navigator.platform); | |||
|
|
|||
| if (Browser.name == 'ie'){ | |||
| Browser.version = document.documentMode; | |||
| Browser.version = document.documentMode/*<ltIE8>*/ || parseFloat(navigator.appVersion.match(/MSIE ([\d.]+)/)[1])/*</ltIE8>*/; | |||
There was a problem hiding this comment.
Doesn't the Browser object at this point already contain the version? And in the case document.documentMode is available, it should that instead.
if (Browser.name == 'ie' && document.documentMode){
Browser.version = document.documentMode;
}
SergioCrisostomo
force-pushed
the
ie-version-fix
branch
from
6824ee0
to
2238f04
Compare
|
@arian that makes much more sense. Updated the pull request. |
| if (Browser.name == 'ie'){ | ||
| Browser.version = document.documentMode; | ||
| if (Browser.name == 'ie' && document.documentMode){ | ||
| Browser.version = document.documentMode; |
There was a problem hiding this comment.
You changed the tab to 4 spaces...
SergioCrisostomo
force-pushed
the
ie-version-fix
branch
from
2238f04
to
a9628d3
Compare
ibolmo
added a commit
that referenced
this pull request
Sep 15, 2014
fix IE version detection in old IE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2652