Skip to content

Commit

Permalink
lighthouse -- 200, Scroller bug: scrolling stops when attached to com…
Browse files Browse the repository at this point in the history
…plex containers

https://mootools.lighthouseapp.com/projects/24057/tickets/200-scroller-bug-scrolling-stops-when-attached-to-complex-containers

- changes mouseover and mouseout to mouseenter and mouseleave and discussed in ticket
- clarifies expected behavior in test
  • Loading branch information
fat committed Sep 17, 2010
1 parent 63296ad commit 17bd662
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
10 changes: 5 additions & 5 deletions Source/Interface/Scroller.js
Original file line number Diff line number Diff line change
Expand Up @@ -51,15 +51,15 @@ var Scroller = new Class({

start: function(){
this.listener.addEvents({
mouseover: this.bound.attach,
mouseout: this.bound.detach
mouseenter: this.bound.attach,
mouseleave: this.bound.detach
});
},

stop: function(){
this.listener.removeEvents({
mouseover: this.bound.attach,
mouseout: this.bound.detach
mouseenter: this.bound.attach,
mouseleave: this.bound.detach
});
this.detach();
this.timer = $clear(this.timer);
Expand Down Expand Up @@ -98,4 +98,4 @@ var Scroller = new Class({
if (change.y || change.x) this.fireEvent('change', [scroll.x + change.x, scroll.y + change.y]);
}

});
});
4 changes: 2 additions & 2 deletions Tests/Interface/Scroller.html
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
</style>

<p>
Drag the red box to the edge of the scrollable area, which should scroll in that direction.
Drag the red box to the edge of the scrollable area, which should scroll in that direction. Scroller shouldn't hiccup on entering/exiting dom elements insde of scroller element.
</p>

<div id="scrollExample" style="height: 300px; overflow: auto; width: 300px;">
Expand Down Expand Up @@ -49,4 +49,4 @@
scr.stop();
}
});
</script>
</script>

0 comments on commit 17bd662

Please sign in to comment.