fixes validator parameters allowing spaces in them

[kulbakin]

The pull request allows validator parameters specified in data-validators attribute (or legacy class) after validator name to have spaces in their values, e.g.

<input type="radio" name="primary_category" data-validators="validate-reqchk-byname label:'primary category'" />
...

[SergioCrisostomo]

I think this is a valid fix, although Docs say:

Note that string values that require spaces should use URL encoding, as spaces are the delimiters for validator names. Then your validator should url decode them from the data-validator-properites object when it uses them. Alternately, you can store this data directly on the input:

Could you add some spec to the PR like:

it('should get the properties from string with spaces', function(){
    var input = new Element('input', {'data-validators': 'label:\'primary category\''});
    expect(input.get('validatorProps')).toEqual({label: "primary category"});
});

They should go here, in the /Specs/Forms/Form.Validator.js file.

[kulbakin]

@SergioCrisostomo added spec as suggested

[anutron]

Good stuff. We should update the documentation for it. Update docs and ship it.

[SergioCrisostomo]

merged/fixed in 8ce4ade

[effetb]

Hi,
It is not working if there is more than one space in the value.
Ex. : data-validators="validate-match matchInput:'password' matchName:'your new password'"

It give me "undefined" instead of "your new password"
Mootools Core : version: '1.6.0', build: '529422872adfff401b901b8b6c7ca5114ee95e2b'
Mootools More : version: '1.6.0', build: '45b71db70f879781a7e0b0d3fb3bb1307c2521eb'

I suggest to modify the second return call in this code :

Element.Properties.validators = {

    get: function(){
        return (this.get('data-validators') || this.className).clean().replace(/'(\\.|[^'])*'|"(\\.|[^"])*"/g, function(match){
            return match.replace(' ', '\\x20');
        }).split(' ');
    }

};

by this

Element.Properties.validators = {

    get: function(){
        return (this.get('data-validators') || this.className).clean().replace(/'(\\.|[^'])*'|"(\\.|[^"])*"/g, function(match){
               return match.split(' ').join('\\x20');
        }).split(' ');
    }

};

Regards

[kulbakin]

indeed, or it could be

return match.replace(/ /g, '\\x20');

[effetb]

Yes you are right.