Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow international special characters in emails - fixes #1305 #1306

Closed
wants to merge 1 commit into from
Closed

Conversation

bhstahl
Copy link

@bhstahl bhstahl commented Apr 16, 2015

The validate-email Regex in Form.Validator blocks special characters that are common in international languages (such as áéíèàùñÑêÊäÄöÖüÜçÇ).

Bug demo: http://jsfiddle.net/bhstahl/sju4nson/2/

Refs #1305

@DimitarChristoff
Copy link
Member

well. this is not alpha numeric. if we go that route, all of these need to
pass as per RFC6530

  • Latin Alphabet (with diacritics): Pelé@example.com
  • Greek Alphabet: δοκιμή@παράδειγμα.δοκιμή
  • Traditional Chinese Characters: 我買@屋企.香港
  • Japanese Characters: 甲斐@黒川.日本
  • Cyrillic Characters: чебурашка@ящик-с-апельсинами.рф

On Thursday, April 16, 2015, Ben Stahl notifications@github.com wrote:


You can view, comment on, or merge this pull request online at:

#1306
Commit Summary

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#1306.

Dimitar Christoff

"JavaScript is to JAVA what hamster is to ham"
@D_mitar - https://github.com/DimitarChristoff

@timwienk
Copy link
Member

See my comments at #1305

@DimitarChristoff
Copy link
Member

exactly. furthermore. HTML5's input[type=email] without a supplied
pattern also fails in the same way, which is OK as you can configure it.

On Thursday, April 16, 2015, Tim Wienk notifications@github.com wrote:

See my comments at #1305
#1305


Reply to this email directly or view it on GitHub
#1306 (comment)
.

Dimitar Christoff

"JavaScript is to JAVA what hamster is to ham"
@D_mitar - https://github.com/DimitarChristoff

@bhstahl
Copy link
Author

bhstahl commented Apr 17, 2015

@timwienk @DimitarChristoff Very fair points, I agree with your stance. It was a use case localized fix for a legacy project, so I figured I would contribute but hadn't considered your points. If I get some time the validate-email-advanced validator would be a nice solution.

@bhstahl bhstahl closed this Apr 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants