Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes wrong module definitions #1311

wants to merge 1 commit into from


Copy link

@IvanGuardado IvanGuardado commented Jun 13, 2015

This PR fixes #1310 and #1294.

Some modules wasn't well defined to use them with a dependency loader.

I've checked all modules and these are what I found:
Drag, Slider, Sortables, OverText, HtmlTable, Mask, Scroller, Spinner, Asset.

I've also changed some modules to follow the same module definition format:
Tips, Group, IframeShim

Although this doesn't make them CommonJS compliance, it's enough to load all modules in the global scope (window).

If you are using webpack, you can include the library with this workaround without any problems now:

Copy link

@SergioCrisostomo SergioCrisostomo commented Jun 13, 2015

Nice! 👍

Copy link

@anutron anutron commented Aug 10, 2015


Also, we should really kill IframeShim. It's only a fix for IE6 I think.

Copy link

@SergioCrisostomo SergioCrisostomo commented Aug 10, 2015

added via 7d29eda

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.