Fixes wrong module definitions #1311

Closed
wants to merge 1 commit into
from

Projects

None yet

3 participants

@IvanGuardado
Contributor

This PR fixes #1310 and #1294.

Some modules wasn't well defined to use them with a dependency loader.

I've checked all modules and these are what I found:
Drag, Slider, Sortables, OverText, HtmlTable, Mask, Scroller, Spinner, Asset.

I've also changed some modules to follow the same module definition format:
Tips, Group, IframeShim

Although this doesn't make them CommonJS compliance, it's enough to load all modules in the global scope (window).

If you are using webpack, you can include the library with this workaround without any problems now:

require('imports?this=>window!path/to/mootools-more-all.js);
@SergioCrisostomo
Member

Nice! 👍

@anutron
Member
anutron commented Aug 10, 2015

👍

Also, we should really kill IframeShim. It's only a fix for IE6 I think.

@SergioCrisostomo
Member

added via 7d29eda

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment