remove old callbacks in Request.JSONP.request_map

[SergioCrisostomo]

fixes #1293

Add option to remove old Request.JSONP.request_map callbacks. Defaults to false to be BC.

[DimitarChristoff]

since that's not official API (the stored responses) BC should be ignored
and data should be removed by default. anyone who's augmented it to use
request_map to cache results clearly know what they are doing and can
adjust their code accordingly imo.

On Tuesday, August 11, 2015, Sergio Crisostomo notifications@github.com
wrote:

fixes #1293 #1293

Add option to remove old Request.JSONP.request_map callbacks. Defaults to

false to be BC.

You can view, comment on, or merge this pull request online at:

#1315
Commit Summary

• remove old callbacks in Request.JSONP.request_map

File Changes

• M Docs/Request/Request.JSONP.md
  https://github.com/mootools/mootools-more/pull/1315/files#diff-0 (1)
• M Source/Request/Request.JSONP.js
  https://github.com/mootools/mootools-more/pull/1315/files#diff-1
  (19)
• M Specs/Request/Request.JSONP.js
  https://github.com/mootools/mootools-more/pull/1315/files#diff-2
  (28)
• M Tests/Specs/assets/jsonp.js
  https://github.com/mootools/mootools-more/pull/1315/files#diff-3 (4)

Patch Links:

• https://github.com/mootools/mootools-more/pull/1315.patch
• https://github.com/mootools/mootools-more/pull/1315.diff

—
Reply to this email directly or view it on GitHub
#1315.

Dimitar Christoff

"JavaScript is to JAVA what hamster is to ham"
@D_mitar - https://github.com/DimitarChristoff

[arian]

Agreed with @DimitarChristoff

[SergioCrisostomo]

Nice feedback! will update soonish and ping back.

[SergioCrisostomo]

@arian @DimitarChristoff updated

[anutron]

Hmmm.

What if the index isn't passed in? If it's required, that's a breaking change.

What if the index passed in isn't the running request?

[DimitarChristoff]

it's not breaking because worst case scenario, it will just try to delete an undefined property.

I have a better fix which does not change the API - storing the index within the script tag, then auto deleting

http://jsfiddle.net/dimitar/frxnqj5q/1/

[anutron]

Good stuff. Might suggest we used data-jsonp-index or something rather than the element attribute, but whatever, it doesn't matter really.

[DimitarChristoff]

i considered it but it's so short lived - initially even thought of storage but that meant storage gc when element is removed. i'd agree about data-prop as it ought to be slightly cheaper.

[DimitarChristoff]

easier fix still. one liner

    Request.JSONP.request_map['request_' + index] = function(){
        delete Request.JSONP.request_map['request_' + index];
        this.success(arguments, index);
    }.bind(this);

so
+ delete Request.JSONP.request_map['request_' + index];

[SergioCrisostomo]

Updated again. No index anymore and using Dimitar's oneliner, much better idea.

[DimitarChristoff]

@SergioCrisostomo check master...DimitarChristoff:SergioCrisostomo-fix1293 - missed an index and such.

[SergioCrisostomo]

Nice! Yeah, that index was already there from before and is unused. Will cherry pick your work and use it. thanks!

Sent from my iPhone

On 12 aug 2015, at 12:19, Dimitar Christoff notifications@github.com wrote:

@SergioCrisostomo check master...DimitarChristoff:SergioCrisostomo-fix1293 - missed an index and such.

—
Reply to this email directly or view it on GitHub.