Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master 475 sortables not cleaning clone #192

Closed
wants to merge 1 commit into from
Closed

Master 475 sortables not cleaning clone #192

wants to merge 1 commit into from

Conversation

fat
Copy link
Contributor

@fat fat commented Jan 7, 2011

lighthouse 475, sortables table adds lots of s
https://mootools.lighthouseapp.com/projects/24057/tickets/475-sortables-table-adds-lots-of-trs#ticket-475-2

cancel is fired from drag on mouseup -- not complete... so if you
click or mousedown on a sortable without dragging -- it was only resetting
sortables... resetting doesn't remove the clone. So we should end on
cancel instead (ending also resets)...

https://mootools.lighthouseapp.com/projects/24057/tickets/475-sortables-table-adds-lots-of-trs#ticket-475-2

cancel is fired from drag move on mouseup -- not complete... so if you
click or mousedown on a sortable with dragging -- it was only resetting
sortables... resetting doesn't remove the clone. So we should end on
cancel instead (ending also resets)...
@arian
Copy link
Member

arian commented Jan 7, 2011

nice!

@fat
Copy link
Contributor Author

fat commented Jan 7, 2011

Wow! You don't sleep do you? :)

@arian
Copy link
Member

arian commented Jan 7, 2011

I'm just awake :P

@arian
Copy link
Member

arian commented Jan 7, 2011

Pushed

CrypticSwarm pushed a commit to CrypticSwarm/mootools-more that referenced this pull request Sep 21, 2011
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants