Develop 378 test this in delegated events #66
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n malfunction https://mootools.lighthouseapp.com/projects/24057-mootoolsmore/tickets/378-this-inside-a-function-triggered-by-event-delegation-malfunction#ticket-378-3 - modifies the test to be a bit more clear with this sort of failure (also as a note, i think this particular issue is for -core, not -more)
|
Exactly. |
|
does this need to be pulled into 1.2x? or just 1.3? The only code change I see looks like one specific to 1.3 stuff. |
|
Ah. I see it needs to go on develop. will pull. |
|
Yeah it's for a bug with -core 1.2.5 :) |
|
this is pulled. Note that I squashed the commits. http://github.com/mootools/mootools-more/commit/82e651af943c24271ed83f031009257bc867d997 cpojer, arian, tim? one of you want to pick this into 1.3? |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lighthouse-378. "this" inside a function triggered by event delegation malfunction
https://mootools.lighthouseapp.com/projects/24057-mootoolsmore/tickets/378-this-inside-a-function-triggered-by-event-delegation-malfunction#ticket-378-3