Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies in builder #171

Closed
timwienk opened this issue Nov 6, 2014 · 1 comment · Fixed by #174
Closed

Dependencies in builder #171

timwienk opened this issue Nov 6, 2014 · 1 comment · Fixed by #174
Milestone

Comments

@timwienk
Copy link
Member

timwienk commented Nov 6, 2014

In the old website, components (or their checkboxes) basically had three states:

  • not selected
  • automatically selected (as dependency)
  • selected

When selecting component A that requires component B, component A would be selected and component B would show as automatically selected. Additionally, this was reflected in the generated build hash (component A would be in the hash, component B wouldn't be).

One of the benefits is that, if component A changes to require more or less other components, the hash would stay the same and the result would still be a package with working selected components.

Another benefit is that, if you deselect component A, all dependencies (that are not manually selected or needed by other components) would be automatically deselected.

Example, from packager-web (which is what the builder from the old website was based on):
builder
Only "Class" is manually selected.

@ibolmo ibolmo added this to the 1.1 milestone Nov 10, 2014
@timwienk
Copy link
Member Author

A package/component in the "automatic" state is still stored in the hash.

When selecting component A that requires component B, component A would be selected and component B would show as automatically selected. Additionally, this was reflected in the generated build hash (component A would be in the hash, component B wouldn't be).

@timwienk timwienk reopened this Nov 12, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants