Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/lint: specify nancy flags properly #224

Merged
merged 1 commit into from
Sep 29, 2021

Conversation

adamdecaf
Copy link
Member

@adamdecaf adamdecaf commented Sep 28, 2021

Dunno if this will work as I've had errors when moving flags before the sub-command, but their code reads like this will work.

https://github.com/sonatype-nexus-community/nancy/blob/533b797f2a7c14d2c9306785e8a92b3c66d41c46/internal/cmd/root.go#L194

We could also set SKIP_UPDATE_CHECK=true in the linter script.
https://github.com/sonatype-nexus-community/go-sona-types/blob/main/configuration/set.go#L237

@codecov-commenter
Copy link

Codecov Report

Merging #224 (c5fa8f5) into master (03685ef) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #224   +/-   ##
=======================================
  Coverage   78.37%   78.37%           
=======================================
  Files           1        1           
  Lines          37       37           
=======================================
  Hits           29       29           
  Misses          4        4           
  Partials        4        4           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03685ef...c5fa8f5. Read the comment docs.

@alexjplant
Copy link
Contributor

Tested and works on my machine.

@adamdecaf adamdecaf merged commit c3928b7 into moov-io:master Sep 29, 2021
@adamdecaf adamdecaf deleted the nancy-root-flags branch September 29, 2021 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants