Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/lint: find the coverage total with a better regex #245

Merged
merged 1 commit into from
Feb 1, 2022

Conversation

adamdecaf
Copy link
Member

We had a build with the follow result from grepping

github.com/moov/secret-project/pkg/summary.go:22:				Subtotal			100.0%
total:										(statements)			80.8%

We had a build with the follow result from grepping

github.com/moov/secret-project/pkg/summary.go:22:				Subtotal			100.0%
total:										(statements)			80.8%
@codecov-commenter
Copy link

Codecov Report

Merging #245 (dc502e4) into master (b8c9723) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #245   +/-   ##
=======================================
  Coverage   78.37%   78.37%           
=======================================
  Files           1        1           
  Lines          37       37           
=======================================
  Hits           29       29           
  Misses          4        4           
  Partials        4        4           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8c9723...dc502e4. Read the comment docs.

@adamdecaf adamdecaf merged commit d117303 into moov-io:master Feb 1, 2022
@adamdecaf adamdecaf deleted the lint-coverage-better-grep branch February 1, 2022 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants