Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/lint: remove gocyclo linter #250

Merged
merged 1 commit into from
Mar 28, 2022
Merged

Conversation

adamdecaf
Copy link
Member

There is a flag to configure this, but it's deprecated:
https://github.com/golangci/golangci-lint/blob/7bbbe77e5e68cdbecad5e25fc44810afd8f3d48c/pkg/commands/run.go#L154-L155

# set some golangci-linter passthrough options
if [[ $GOLANGCI_FLAGS == "" ]];
then
    GOLANGCI_FLAGS="--gocyclo.min-complexity=50"
fi
Flag --gocyclo.min-complexity has been deprecated, flag will be removed soon, please, use .golangci.yml config

So we should just remove this. Setting .golangci.yml isn't something I want moov-io/infra's script to deal with.

@adamdecaf adamdecaf merged commit 020a942 into moov-io:master Mar 28, 2022
@adamdecaf adamdecaf deleted the remove-gocyclo branch March 28, 2022 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants