Missing node types (comment and processing-instruction) #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the missing node types needed for outputting complete XML documents (namely, comment and processing-instruction nodes). All seven node types defined in the XML spec can now be read, created, and serialized using gokogiri.
| @@ -194,6 +196,17 @@ func (document *XmlDocument) Root() (element *ElementNode) { | |||
| return | |||
| } | |||
|
|
|||
| func (document *XmlDocument) NodeById(id string) (element *ElementNode) { | |||
There was a problem hiding this comment.
Could you add a test case for this method?
|
Everything looks really good! Thanks again for the contribution! Once you add a test case for the NodeByID method, we'll go ahead and merge it in ^.^ |
|
I've added a documentation string and a test case. |
|
Looks good! Merging in! Thanks again for the contribution, we really appreciate it ^.^ |
mdayaram
added a commit
that referenced
this pull request
Oct 14, 2013
Missing node types (comment and processing-instruction)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for the missing node types comment and processing-instruction, allowing them to be created, recognized during parsing, and used for type switching.