Set the correct node pos for unary nodes #464
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, prefix unary nodes have their
pos
attribute set to the start of their argument rather than the start of the operator. This causes issues withjs2-node-at-point
and similar. This PR goes through all these node creation sites and sets the correct attribute. I guess it's technically a breaking change since it adds a non-optional argument tojs2-make-unary
, though that strikes me as an internal function.