fix for removal of support for let expressions from spider monkey #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -491,8 +496,9 @@ var ksBuiltin = { | |||
| if (!command.kill.ring.length) | |||
| return; | |||
|
|
|||
| let (ct = command.getClipboardText()) | |||
| let (ct = command.getClipboardText()) { | |||
There was a problem hiding this comment.
For completeness: actually only this instance gave me problems, but changed the others too as they looked suspect
|
Thanks for the patch. Actually let expression (let w/o I'll fix the errors in the next version. Thanks for the report. |
|
let statements are also deprecated, and will be dropped in a future version of Firefox. I'll try to remove let expression/statement completely from KeySnail's codebase. |
|
Removed in c476cee |
|
thanks a ton 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keysnail stopped working for me after ubuntu updated my firefox to version 41.0.
Got an error referring to a missing '{' near a let block. Fixed my .keysnail.js file locally.
A bit of searching got me the link referenced in the commit message. Found it via https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/let in the section on 'let expressions'.