Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow meghanada to support hooks after a test is executed #127

Merged
merged 1 commit into from Nov 12, 2018

Conversation

roman
Copy link
Contributor

@roman roman commented Nov 7, 2018

Hey @mopemope

Just wanted to thank you for this package, is great, makes Java development experience somewhat bearable.

I'm adding a functionality to allow interested packages to get notified when a JUnit test-suite finishes. Following is an example of what kind of stuff I do with this hook on my personal setup.

meghanada after save example

Notice the highlights of the mode-line whenever a test starts executing, a green highlight when it passes and a red highlight when it doesn't.

Thank you for considering this pull request.

@roman
Copy link
Contributor Author

roman commented Nov 9, 2018

Also, I think this hook may be improved by adding the test counts (success, failure, ignored) as parameters for the hook. Given that we control the format of the JUnit buffer, we can reliably get the numbers from the buffer before calling running the hooks. What are your thoughts?

@roman
Copy link
Contributor Author

roman commented Nov 12, 2018

@mopemope is this project no longer maintained?

@mopemope
Copy link
Owner

@roman Sorry I'm here. I also think that customizing hooks is a good idea.

@mopemope mopemope merged commit 13c4a7d into mopemope:master Nov 12, 2018
@mopemope
Copy link
Owner

@roman Merged. Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants