Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for CamelCase auto completion #99

Merged
merged 2 commits into from
May 14, 2018
Merged

Conversation

xqliu
Copy link
Contributor

@xqliu xqliu commented May 13, 2018

Add support for CamelCase auto completion, also fix an issue that the prefix is always empty when do method completion when comes to branch ((string-match "\.\(\w*\)$" match)

xqliu and others added 2 commits May 14, 2018 04:58
Fix an issue that the prefix is always empty when do method completion,
Copy link
Owner

@mopemope mopemope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution.

This seems to have no change.Could you confirm it ?

@xqliu
Copy link
Contributor Author

xqliu commented May 14, 2018

Dear, I just swap the cond sequence, which I observe that if

(prefix (match-string 1 match))

is after

(paren (meghanada--last-is-paren))

Then, prefix will always be empty when send to meghanada-server, I have move prefix assignment in front of paren assignment and now, prefix will get correct value when passing to meghanada-server.

Not know the exactly reason since I am new to lisp.

@mopemope mopemope merged commit bec15ed into mopemope:dev May 14, 2018
@mopemope
Copy link
Owner

@xqliu Merged. Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants