Small fixes #45
Merged
Small fixes #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously no timeout was used at all. This surely lead to some usability issues in case of temporary network problems.
Previously during the extension setup a connection was attempted once and the success state of this attempt was memorized. In later search queries a stored failure caused the backend query to be skipped. This lead to two problems: * Not all requests took the initial connection test result into account (i.e. some queries were skipped and some were not). * The initial connection test result was not updated during the life time of the extension (i.e. until the next restart of Mopidy). Thus, a broken connection could never recover.
The listing was broken since commit 1e9ca37. Now we enforce the string conversion for browse item names again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While preparing some new test code a few minor details were fixed.