HTTP errors cause the Mopidy actor to die #11
Comments
|
I've created PR #12 which contains a potential solution, but it won't work until mopidy/mopidy#17 has been fixed for repeat mode as well (also see mopidy/mopidy#1221). ...made worse by: https://github.com/mopidy/mopidy/blob/749c8baceb077f8a5155e1dab33b7154ab1ba481/mopidy/core/playback.py#L361-363 - just returning |
|
Could be related to mopidy/mopidy#667 which was recently closed - so the actor should not die in the upcoming release of Mopidy 1.1.0 anymore if unhandled exceptions are encountered. I believe that the expectation is still that Mopidy extensions should handle all of their own exceptions however, and not to rely on core to recover gracefully. At the moment the Mopidy core will just log the exception without any further error handling being done. |
|
Update: this is still an issue in Mopidy 1.0.8 as playback is not covered by the new backend exception handling logic (see mopidy/mopidy#1163 for details). Recent stack trace below: 2015-08-02 07:36:04,599 - WARNING Retrying (Retry(total=0, connect=None, read=None, redirect=None)) after connection broken by 'ProtocolError('Connection aborted.', BadStatusLine("''",))': /access/7768654303429234367.mp4?version=4&lid=1909531839&token=vpiKAZ1IuDx1yxflYc%2BFCN |
|
The code in the 'Develop' branch is a lot better at checking and preventing exceptions in the mopidy-pandora back-end. I am not aware of any unhandled exceptions that are not covered there at this stage. @rectalogic, I'm not sure if the exception handling will be ported back to the 'Master' branch or if we will just merge the two when the time is right? |
|
@jcass77 if you've been running on develop with no issues, then I'll just merge it into master. |
|
I've been running https://github.com/jcass77/mopidy-pandora/tree/feature/thumbs_support (which is forked off 'Develop') for the last two weeks without issues. So I think we are safe but would be good if someone else could also give the 'Develop' branch a try first. |
|
Closing now that develop is merged to master. |
HTTP connection and timeout errors raise exceptions which are not currently handled. This sometimes causes the Mopidy backend to die unexpectedly:
2015-06-26 03:39:56,619 - ERROR Unhandled exception in Core (urn:uuid:dc95f4be-887d-4bcf-a332-2d6cced5309f): Traceback (most recent call last): File "/usr/local/lib/python2.7/dist-packages/pykka/actor.py", line 200, in _actor_loop response = self._handle_receive(message) File "/usr/local/lib/python2.7/dist-packages/pykka/actor.py", line 294, in _handle_receive return callee(*message['args'], **message['kwargs']) File "/var/lib/git/mopidy/mopidy/listener.py", line 49, in on_event getattr(self, event)(**kwargs) File "/var/lib/git/mopidy/mopidy/core/actor.py", line 87, in reached_end_of_stream self.playback._on_end_of_track() File "/var/lib/git/mopidy/mopidy/core/playback.py", line 217, in _on_end_of_track self._change_track(next_tl_track) File "/var/lib/git/mopidy/mopidy/core/playback.py", line 199, in _change_track self._play(on_error_step=on_error_step) File "/var/lib/git/mopidy/mopidy/core/playback.py", line 313, in _play backend.playback.change_track(tl_track.track).get() and File "/usr/local/lib/python2.7/dist-packages/pykka/future.py", line 299, in get exec('raise exc_info[0], exc_info[1], exc_info[2]') File "/usr/local/lib/python2.7/dist-packages/pykka/actor.py", line 200, in _actor_loop response = self._handle_receive(message) File "/usr/local/lib/python2.7/dist-packages/pykka/actor.py", line 294, in _handle_receive return callee(*message['args'], **message['kwargs']) File "/var/lib/git/mopidy-pandora/mopidy_pandora/actor.py", line 60, in change_track pandora_track = self._next_track(track_uri.station_token) File "/var/lib/git/mopidy-pandora/mopidy_pandora/actor.py", line 50, in _next_track self.tracks = self.backend.api.get_playlist(station_token) File "/var/lib/git/mopidy-pandora/mopidy_pandora/pydora.py", line 10, in with_authentication return f(self, *args, **kwargs) File "/var/lib/git/mopidy-pandora/mopidy_pandora/pydora.py", line 66, in get_playlist for station in self.api.get_playlist(station_token)['items']) File "/var/lib/git/pydora/pandora/__init__.py", line 308, in get_playlist includeTrackLength=True) File "/var/lib/git/pydora/pandora/__init__.py", line 172, in __call__ result = self._make_http_request(url, data) File "/var/lib/git/pydora/pandora/__init__.py", line 130, in _make_http_request return urlopen(req) File "/usr/lib/python2.7/urllib2.py", line 127, in urlopen return _opener.open(url, data, timeout) File "/usr/lib/python2.7/urllib2.py", line 401, in open response = self._open(req, data) File "/usr/lib/python2.7/urllib2.py", line 419, in _open '_open', req) File "/usr/lib/python2.7/urllib2.py", line 379, in _call_chain result = func(*args) File "/usr/lib/python2.7/urllib2.py", line 1219, in https_open return self.do_open(httplib.HTTPSConnection, req) File "/usr/lib/python2.7/urllib2.py", line 1181, in do_open raise URLError(err) URLError: <urlopen error [Errno 110] Connection timed out> 2015-06-26 03:39:56,724 - WARNING Tried to communicate with dead actor. 2015-06-26 03:39:56,729 - WARNING Tried to communicate with dead actor. 2015-06-26 03:39:56,733 - WARNING Tried to communicate with dead actor. 2015-06-26 03:39:56,737 - WARNING Tried to communicate with dead actor. 2015-06-26 03:39:56,740 - WARNING Tried to communicate with dead actor.The text was updated successfully, but these errors were encountered: