Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle HTTP-related errors #12

Closed
wants to merge 2 commits into from
Closed

Handle HTTP-related errors #12

wants to merge 2 commits into from

Conversation

jcass77
Copy link
Member

@jcass77 jcass77 commented Jun 26, 2015

The backend should handle HTTP-related errors like timeouts and connection failures, instead of leaving it to the Mopidy core.

Dependent on a fix being released for mopidy/mopidy#1221

@rectalogic
Copy link
Contributor

It seems bad to swallow these exceptions in the backend and tell mopidy there is no track available (returning None from _next_track). How will the user know something went wrong or what to do? It seems like Mopidy should be catching exceptions raised by backends and the front end can report an error to the user using whatever UI it has and the user can reload the playlist or whatever.

@jcass77
Copy link
Member Author

jcass77 commented Jun 26, 2015

Agreed. I may be missing something but have not found a way to implement the behaviour you described.

Looking at the Mopidy issue linked above, it seems like Mopidy currently also just skips tracks that it cannot play...not sure how to expose this in the UI.

@jcass77
Copy link
Member Author

jcass77 commented Jul 25, 2015

Not being able to display error messages to users is a known issue in Mopidy, see mopidy/mopidy#1011

@jcass77
Copy link
Member Author

jcass77 commented Aug 19, 2015

Fixed in merged 'Develop' branch.

@jcass77 jcass77 closed this Aug 19, 2015
@jcass77 jcass77 deleted the bug/11-handle-http-errors branch August 21, 2015 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants