Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unplayable tracks are not consumed in consume mode #1358

Closed
jcass77 opened this issue Dec 11, 2015 · 2 comments
Closed

Unplayable tracks are not consumed in consume mode #1358

jcass77 opened this issue Dec 11, 2015 · 2 comments

Comments

@jcass77
Copy link
Member

jcass77 commented Dec 11, 2015

Unplayable tracks should be removed from the tracklist when consume mode is turned on, just like regular playable tracks.

When consume mode is turned on, tracks are removed from the tracklist as they are played:

def _mark_played(self, tl_track):
"""Internal method for :class:`mopidy.core.PlaybackController`."""
if self.consume and tl_track is not None:
self.remove({'tlid': [tl_track.tlid]})
return True
return False

However if the track is not playable it will simply be logged and left in the tracklist:

def _mark_unplayable(self, tl_track):
"""Internal method for :class:`mopidy.core.PlaybackController`."""
logger.warning('Track is not playable: %s', tl_track.track.uri)
if self.get_random() and tl_track in self._shuffled:
self._shuffled.remove(tl_track)

jcass77 added a commit to jcass77/mopidy that referenced this issue Dec 11, 2015
@jcass77
Copy link
Member Author

jcass77 commented Dec 11, 2015

This may not be a valid issue - see #1359

@jodal
Copy link
Member

jodal commented Dec 11, 2015

Then let's close this and work on merging #1359 :-)

@jodal jodal closed this as completed Dec 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants