New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/scan_force_arg #1010

Merged
merged 4 commits into from Mar 1, 2015

Conversation

3 participants
@RonaldZ
Contributor

RonaldZ commented Feb 26, 2015

In issue #910 an enhancement was requested to add a --force argument to the scan command.

Also, while working on #910 I noticed the help text for --limit had a miss-spelled word so went ahead and fixed that.

help='Maxmimum number of tracks to scan')
help='Maximum number of tracks to scan')
self.add_argument('--force',
action='store_true',dest='force',default=False,

This comment has been minimized.

@jodal

jodal Feb 26, 2015

Member

Missing spaces after the commas here. Will break flake8 linting when Travis CI gets up to speed again.

help='Maximum number of tracks to scan')
self.add_argument('--force',
action='store_true',dest='force',default=False,
help='Forces the scanner to re-scan all media files')

This comment has been minimized.

@jodal

jodal Feb 26, 2015

Member

Maybe simply "Force rescan of all media files"?

@jodal

This comment has been minimized.

Member

jodal commented Feb 26, 2015

All in all, looks simple and good. :-)

Either you (change locally and force-push to your branch, and the PR will be updated) or the one merging this should take the time to clean up the commit history to two commits:

  • Fixing the "maximum" typo
  • Adding the --force flag

@jodal jodal added this to the v0.20 - Audio cleanup 1 milestone Feb 26, 2015

@jodal jodal added the 2 - Working label Feb 26, 2015

@RonaldZ

This comment has been minimized.

Contributor

RonaldZ commented Feb 27, 2015

Added the spaces, shortened the help to your suggestion, and slimmed it down to two commits.

@adamcik

This comment has been minimized.

Member

adamcik commented Mar 1, 2015

https://travis-ci.org/mopidy/mopidy/jobs/52370009 is still reporting style issues (one of which I think was even there from before). Get those fixed (and for bonus points update the changelog and docs) and this is ready to merge :-)

adamcik added a commit that referenced this pull request Mar 1, 2015

Merge pull request #1010 from RonaldZ/feature/scan_force_arg
local: Add --force flag to 'mopidy local scan' command

@adamcik adamcik merged commit ec65a2e into mopidy:develop Mar 1, 2015

2 checks passed

Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jodal jodal removed the 2 - Working label Mar 27, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment