Feature/scan_force_arg #1010
Merged
Feature/scan_force_arg #1010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| help='Maxmimum number of tracks to scan') | ||
| help='Maximum number of tracks to scan') | ||
| self.add_argument('--force', | ||
| action='store_true',dest='force',default=False, |
There was a problem hiding this comment.
Missing spaces after the commas here. Will break flake8 linting when Travis CI gets up to speed again.
|
All in all, looks simple and good. :-) Either you (change locally and force-push to your branch, and the PR will be updated) or the one merging this should take the time to clean up the commit history to two commits:
|
|
Added the spaces, shortened the help to your suggestion, and slimmed it down to two commits. |
|
https://travis-ci.org/mopidy/mopidy/jobs/52370009 is still reporting style issues (one of which I think was even there from before). Get those fixed (and for bonus points update the changelog and docs) and this is ready to merge :-) |
adamcik
added a commit
that referenced
this pull request
Mar 1, 2015
local: Add --force flag to 'mopidy local scan' command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In issue #910 an enhancement was requested to add a
--forceargument to the scan command.Also, while working on #910 I noticed the help text for
--limithad a miss-spelled word so went ahead and fixed that.