-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/gstreamer not pushing tags 2 #1487
Fix/gstreamer not pushing tags 2 #1487
Conversation
313c942
to
1101823
Compare
Some timings comparisons:
|
a5d8dd7
to
c10c393
Compare
Thank you so much for figuring this out, getting it all fixed upstream and taking the time to make this workaround and do the regression testing. Sadly I haven't had a chance to look more closely over the code, as things have been rather hectic lately. But we'll hopefully get it into a 2.0.1 release as soon as we can. |
Cherry-picked over to release-2.0 and simplified the logic a bit in e9137e1 also added the missing changelog. Will be merged into develop shortly. Thanks for the fix :-) |
Take 2 (replaces #1485):
This applies a workaround for #935, #1453, #1474 and #1480 until gstreamer upstream fix percolates down (gstreamer 1.6.4 or 1.7.91).
I tested on my Arch box with previously problematic .flac files and gstreamer 1.6.3. All tags were picked up and there was no apparent loss of speed (relative to gstreamer compiled from git master).
The main fix is in 2eb43f2, the other two commits are just economising a bit of code and so can be left off if desired.