Prep work for adding a mopidy config --set ... type command.
#548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds markers to configs files that ensures configparser won't mangle comments in the files. Will be combined with a postprocessor that undoes these changes.
Idea forward from here is that once we have a config sub command that we expose a setting config values which will: 1. Run the preprocessor on the file to edit. 2. Load it into config parser. 3. Modify the value. 4. Write it to a io.ByteString 5. Run the postprocessor 6. Save the file with comments etc intact.
| line = blank_line_re.sub(newlines, line) | ||
| line = section_re.sub(sections, line) | ||
| line = comment_re.sub(comments, line) | ||
| line = inline_comment_re.sub(inlinecomments, line) |
There was a problem hiding this comment.
Must the regexps and transformations be applied in a specific order for it to work correctly?
I would like the functions and their use to be sorted in the same order.
There was a problem hiding this comment.
Order does matter because say # foo ; bar needs to become __HASH__ = foo\n__INLINE__ = bar or else the second part disappears as a comment.
|
LGTM. Merge now or after release, at your leisure. Probably no point in including it in 0.16 though, as it is still dead code. |
jodal
added a commit
that referenced
this pull request
Oct 27, 2013
Prep work for adding a `mopidy config --set ...` type command.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the forward and backwards transformations we need for modifying configs while keeping comments etc.