-
Notifications
You must be signed in to change notification settings - Fork 686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support 'list albumartist' #555
Conversation
Flake warnings "breaking" the build. |
@@ -236,6 +238,18 @@ def _list_artist(context, query): | |||
return artists | |||
|
|||
|
|||
def _list_albumartist(context, query): | |||
import logging |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stray logging again? If you really need this it belongs at the top of the file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is just stray, need to check better for these.
Also, I need to push the new testcases to this PR instead of the track_no one in #554 :)
Rebased, added a check for if |
Cheers, thanks. |
Make "list albumartist" work.