Fix track_no #554
Closed
Fix track_no #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems to still have tests failures. |
| @@ -92,8 +88,14 @@ def find_exact(self, query=None, uris=None): | |||
| result_tracks = filter(album_filter, result_tracks) | |||
| elif field == 'artist': | |||
| result_tracks = filter(artist_filter, result_tracks) | |||
| #import logging | |||
There was a problem hiding this comment.
Stray logging / commented code that needs to be removed before a merge :-)
|
The testcase failures are an absolute brain-fart - I made them for another PR :-P |
|
Rebased and merged in 88933fa. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While doing some cleanup work I inadvertently broke "find .... track X" - this fixes it.
Also, remove track_no from any filter as it requires that the parameter can be used with int() and it seems unlikely you would ever do an any search on the track_no.