Audio volume and mute updates from external changes #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 21, 2013 14:26
core: Handle updates on mute and volume
|
Are you planning to implement tests for this also? |
|
No idea on how to test it automatically ;( I don't know how to change the volume of the playbin from outside the app... Help is welcomed! |
|
At the very least you could just trigger the callbacks to check that the right listeners get triggered. |
|
I am having big trouble with this branch. Thought working properly in my machine, slower devices seem to hang-up. I have been testing it in my master branch, and it gets blocked. I need to test it more. Help is welcome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I have coded the playbin part, and also the mixer part, though I haven't been able to test the mixer.