Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/connack with capabilities #709

Merged

Conversation

andsel
Copy link
Collaborator

@andsel andsel commented Jan 28, 2023

What does this PR do?

Adds CONNACK properties, in particular return which capabilities are actually enabled.

@andsel andsel self-assigned this Jan 28, 2023
@andsel andsel mentioned this pull request Jan 28, 2023
27 tasks
@andsel andsel changed the base branch from main to mqtt5_development January 29, 2023 10:13
@andsel andsel added the mqtt5 label Jan 29, 2023
@andsel andsel marked this pull request as ready for review January 29, 2023 10:20
@andsel andsel merged commit 0fc3936 into moquette-io:mqtt5_development Jan 29, 2023
andsel added a commit to andsel/moquette that referenced this pull request Jan 29, 2023
…actually enabled (moquette-io#709)

* Added CONNACK capabilities
* Extracted common shared code in abstract superclass
* Fixed empty clientId management for MQTT5
* Added checks for majority of CONNACK properties, in particular assignedClientId
* Introduce isProtocolVersion, and redefine isNotProtocolVersion
andsel added a commit to andsel/moquette that referenced this pull request Feb 3, 2023
…actually enabled (moquette-io#709)

* Added CONNACK capabilities
* Extracted common shared code in abstract superclass
* Fixed empty clientId management for MQTT5
* Added checks for majority of CONNACK properties, in particular assignedClientId
* Introduce isProtocolVersion, and redefine isNotProtocolVersion
andsel added a commit to andsel/moquette that referenced this pull request Feb 5, 2023
…actually enabled (moquette-io#709)

* Added CONNACK capabilities
* Extracted common shared code in abstract superclass
* Fixed empty clientId management for MQTT5
* Added checks for majority of CONNACK properties, in particular assignedClientId
* Introduce isProtocolVersion, and redefine isNotProtocolVersion
andsel added a commit to andsel/moquette that referenced this pull request Mar 17, 2023
…actually enabled (moquette-io#709)

* Added CONNACK capabilities
* Extracted common shared code in abstract superclass
* Fixed empty clientId management for MQTT5
* Added checks for majority of CONNACK properties, in particular assignedClientId
* Introduce isProtocolVersion, and redefine isNotProtocolVersion
andsel added a commit to andsel/moquette that referenced this pull request Mar 18, 2023
…actually enabled (moquette-io#709)

* Added CONNACK capabilities
* Extracted common shared code in abstract superclass
* Fixed empty clientId management for MQTT5
* Added checks for majority of CONNACK properties, in particular assignedClientId
* Introduce isProtocolVersion, and redefine isNotProtocolVersion
andsel added a commit to andsel/moquette that referenced this pull request Jun 3, 2023
…actually enabled (moquette-io#709)

* Added CONNACK capabilities
* Extracted common shared code in abstract superclass
* Fixed empty clientId management for MQTT5
* Added checks for majority of CONNACK properties, in particular assignedClientId
* Introduce isProtocolVersion, and redefine isNotProtocolVersion
andsel added a commit to andsel/moquette that referenced this pull request Jul 31, 2023
…actually enabled (moquette-io#709)

* Added CONNACK capabilities
* Extracted common shared code in abstract superclass
* Fixed empty clientId management for MQTT5
* Added checks for majority of CONNACK properties, in particular assignedClientId
* Introduce isProtocolVersion, and redefine isNotProtocolVersion
@andsel andsel mentioned this pull request Jul 31, 2023
andsel added a commit to andsel/moquette that referenced this pull request Jul 31, 2023
…actually enabled (moquette-io#709)

* Added CONNACK capabilities
* Extracted common shared code in abstract superclass
* Fixed empty clientId management for MQTT5
* Added checks for majority of CONNACK properties, in particular assignedClientId
* Introduce isProtocolVersion, and redefine isNotProtocolVersion
andsel added a commit that referenced this pull request Jul 31, 2023
Wrap up some MQTT5 work in progress from branch https://github.com/moquette-io/moquette/tree/mqtt5_development  to `main`

The PR that are contained: 
- #697
- #709
- #713
- #753
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant