Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store subscription indentifier into subscriptions trie #804

Conversation

andsel
Copy link
Collaborator

@andsel andsel commented Jan 1, 2024

Release notes

Store and retrieve the subscription identifier into the subscriptions directory.

What does this PR do?

Spread the SubscriptionIdentifier of a subscription request down to the SubscriptionDirectory.
Updated the CNode 's addSubscriptionto update subscriptions stored also if the subscription identifier changes (by value, removing or adding int).

Why is it important/What is the impact to the user?

It's a step in the implementation of subscription id functionality

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files (and/or docker env variables)
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the Changelog if it's a feature or a fix that has to be reported

Related issues

Use cases

…edSubscription to optionally include the subscription identifier, and added tests
@andsel andsel self-assigned this Jan 1, 2024
@andsel andsel mentioned this pull request Jan 1, 2024
4 tasks
@andsel andsel merged commit 8480e22 into moquette-io:main Jan 1, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant