Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements subscription options retain as published feature #815

Conversation

andsel
Copy link
Collaborator

@andsel andsel commented Feb 4, 2024

Release notes

Implements subscription options retain as published feature

What does this PR do?

  • Fixed publish of retained message to have the retained flag set.
  • Fixed existing integration test to avoid interference in tests (ada1602)
  • Added test cases to verify retain as published.
  • Implemented retain as published to forward retain flag only when requested.

Why is it important/What is the impact to the user?

Implement "retain as published" feature

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files (and/or docker env variables)
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the Changelog if it's a feature or a fix that has to be reported

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

@andsel andsel added the mqtt5 label Feb 4, 2024
@andsel andsel self-assigned this Feb 4, 2024
@andsel andsel mentioned this pull request Feb 4, 2024
5 tasks
…ue of the reatain contained in publish message and in publishToSession determine the retain flag to apply on the forwarding message based on the subscription option, for each option
@andsel andsel changed the title [WIP]subscription options retain as published Implements subscription options retain as published feature Feb 4, 2024
@andsel andsel added the feature label Feb 4, 2024
@andsel andsel marked this pull request as ready for review February 4, 2024 18:07
@andsel andsel merged commit 0b92f0f into moquette-io:main Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant