Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update message expiry remaining time and drop queued messages if expired #823

Merged

Conversation

andsel
Copy link
Collaborator

@andsel andsel commented Mar 29, 2024

Release notes

Update the message expiry property remaining seconds when a publish is forwarded.
Updates SerDes for segmented queues to store also the message expiry value.

What does this PR do?

Updates the message expiry property, during forwarding of a publish, with the remaining seconds before expire.
This is done after extract a message from the Session's queue and before composing the publish message to forward.

Why is it important/What is the impact to the user?

Completes the management of the message expiry property

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files (and/or docker env variables)
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the Changelog if it's a feature or a fix that has to be reported

Related issues

@andsel andsel changed the title Feature/message expiry update remaining time Update message expiry remaining time and drop queued messages if expired Mar 31, 2024
@andsel andsel self-assigned this Mar 31, 2024
@andsel andsel force-pushed the feature/message_expiry_update_remaining_time branch from f6dd556 to f8d36d8 Compare March 31, 2024 07:37
@andsel andsel marked this pull request as ready for review March 31, 2024 07:39
@andsel andsel merged commit dd1600d into moquette-io:main Apr 1, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant