Fixed ExpirationService not shutting down Executor #835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andsel
requested changes
Apr 30, 2024
| @@ -25,13 +25,14 @@ public class ScheduledExpirationService<T extends Expirable> { | |||
| private final ScheduledFuture<?> expiredEntityTask; | |||
| private final Clock clock; | |||
| private final Consumer<T> action; | |||
| ScheduledExecutorService actionsExecutor; | |||
There was a problem hiding this comment.
Given that actionsExecutor is assigned only once in the constructor, this can be
Suggested change
| ScheduledExecutorService actionsExecutor; | |
| private final ScheduledExecutorService actionsExecutor; |
hylkevds
force-pushed
the
fix_executorShutdown
branch
from
2bb57b1
to
3370b04
Compare
|
Thank's @hylkevds for fixing it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When shutting down the server the Executor Threads in ScheduledExpirationService instances were not terminated, resulting in a hanging server that would not shut down.