Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement response-information property for request-response flow #840

Merged
merged 7 commits into from
Jul 20, 2024

Conversation

andsel
Copy link
Collaborator

@andsel andsel commented Jun 2, 2024

Release notes

Implement response-information property for request-response flow.

What does this PR do?

  • [feature] Updates the executeConnect to return the property response-information in CONNACT if the property request-response-information is set in CONNECT message. The response-information property contains the topic used by the responder to respond to the requester and consequently updates the read access map so that the requester can listen for new PUBLIUSH on that topic.
  • [test] Extracted common test behavior in AbstractServerIntegrationWithoutClientFixture to share fixture startup of just broker without any client.

Why is it important/What is the impact to the user?

Implement the request-response-information flow used by MQTT5

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files (and/or docker env variables)
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the Changelog if it's a feature or a fix that has to be reported

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

@andsel andsel self-assigned this Jun 2, 2024
@andsel andsel marked this pull request as ready for review July 14, 2024 15:12
@andsel andsel changed the title Feature/request response Implement response-information property for request-response flow Jul 14, 2024
@andsel andsel merged commit c713730 into moquette-io:main Jul 20, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request / Response: Formalize the request/response pattern within MQTT
1 participant